Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full review post-trial 01 #53

Merged
merged 10 commits into from
May 4, 2024
Merged

full review post-trial 01 #53

merged 10 commits into from
May 4, 2024

Conversation

avallecam
Copy link
Member

@avallecam avallecam commented Apr 8, 2024

This aims to collect edit suggestions from trial 01

Fix #55
Fix #56
Fix #58
Fix #60
Fix #63
Fix #65

Copy link

github-actions bot commented Apr 8, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-early/compare/md-outputs..md-outputs-PR-53

The following changes were observed in the rendered markdown documents:

 delays-functions.md                                |  26 ++-
 delays-reuse.md                                    |  10 +
 ...elays-functions-rendered-unnamed-chunk-16-1.png | Bin 50108 -> 50401 bytes
 ...elays-functions-rendered-unnamed-chunk-17-1.png | Bin 50509 -> 51855 bytes
 ...elays-functions-rendered-unnamed-chunk-20-1.png | Bin 51085 -> 51554 bytes
 ...elays-functions-rendered-unnamed-chunk-21-1.png | Bin 32847 -> 32961 bytes
 ...ssibility-rendered-unnamed-chunk-16-1.png (new) | Bin 0 -> 31490 bytes
 ...ransmissibility-rendered-unnamed-chunk-17-1.png | Bin 31022 -> 30519 bytes
 ...ssibility-rendered-unnamed-chunk-20-1.png (new) | Bin 0 -> 84805 bytes
 md5sum.txt                                         |   8 +-
 quantify-transmissibility.md                       | 238 +++++++++++----------
 setup.md                                           |  86 +++++++-
 12 files changed, 241 insertions(+), 127 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-04 04:09:00 +0000

@avallecam avallecam changed the title full review pre trial full review from trial Apr 10, 2024
@avallecam avallecam self-assigned this Apr 10, 2024
@avallecam avallecam marked this pull request as ready for review April 10, 2024 11:29
@avallecam avallecam changed the title full review from trial full review from trial 01 Apr 10, 2024
@avallecam avallecam changed the title full review from trial 01 full review post-trial 01 Apr 10, 2024
@avallecam avallecam changed the base branch from empty to main April 29, 2024 20:06
@avallecam
Copy link
Member Author

@Degoot-AM, can we have your brief review on these few commits to fix some issues identified in trial 01?

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
github-actions bot pushed a commit that referenced this pull request May 4, 2024
github-actions bot pushed a commit that referenced this pull request May 4, 2024
@avallecam avallecam merged commit 63601ff into main May 4, 2024
4 checks passed
@avallecam avallecam deleted the full/review-trial branch May 4, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
1 participant